Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests for each module into `modules/<submodule>/test` #960

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 8, 2019

For #724

Background

  • Our monorepos (in this case luma.gl) are becoming big and it gets hard to track related code across big top-level directory hierarchies. idea is to have src and test next to each other in each submodule.
  • This was already done for newer modules, this PR takes care of the rest of the code base.

Change List

  • Moves test folders from test/modules/<submodule> to modules//test(parallel withmodules//src`
  • Temporarily comment out gltf render tests. They imported code from the examples folder which lead to conflicting versions of e.g. loaders.gl that broke tests on my environment. This needs to be solved before we re-enable so that tests do not depend on installing examples.

@ibgreen ibgreen requested review from Pessimistress, georgios-uber, jianhuang01 and tsherif and removed request for Pessimistress and georgios-uber Mar 8, 2019

// Imports tests for all modules that do not depend on WebGL

// Shadertools is a GLSL textual processing library, no actual WebGL dependencies
import '@luma.gl/shadertools/../test';

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 8, 2019

Contributor

This is not going to work per the current set up, see uber-web/loaders.gl#115 (comment)

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 11, 2019

Author Contributor

This is not going to work per the current set up, see uber-web/loaders.gl#115 (comment)

Updated to work with dist testing.

@ibgreen ibgreen force-pushed the ib/per-module-tests branch from 843ca57 to ce40196 Mar 11, 2019

@ibgreen ibgreen requested a review from Pessimistress Mar 11, 2019

@ibgreen ibgreen force-pushed the ib/per-module-tests branch from ce40196 to a0458bf Mar 11, 2019

@ibgreen

This comment has been minimized.

Copy link
Contributor Author

ibgreen commented Mar 11, 2019

Waited for ocular-dev-tools to land and rebased as discussed.

@ibgreen ibgreen merged commit b40ce3b into master Mar 11, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/per-module-tests branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.