Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer docs for lighting functionality #961

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@georgios-uber
Copy link
Contributor

georgios-uber commented Mar 9, 2019

No description provided.

@georgios-uber georgios-uber self-assigned this Mar 9, 2019

@georgios-uber georgios-uber requested review from ibgreen and jianhuang01 Mar 9, 2019

@georgios-uber georgios-uber marked this pull request as ready for review Mar 12, 2019

# Lighting

Luma.gl supports different shading modules.
To make

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 12, 2019

Contributor

to make what?


## Currently supported lighting models
- Phong (Available in the `phong-lighting` module)
- PBR (Available in the `pbr` module)

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 12, 2019

Contributor

better to link the Phong and PBR module folder or code file, and remove the comment in ()

## Light Sources

## Example
You can use the `lighting` example to play with lights.

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 12, 2019

Contributor

better to change lighting to [lighting](link to example)

- Phong (Available in the `phong-lighting` module)
- PBR (Available in the `pbr` module)

## Accepting lights in your shader module

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 13, 2019

Contributor

I think most developers will want to know how to set up lights and how to use materials.

The only devs who need to know about the uniforms are those who write a new Material / shader stack or do other advanced things.

Maybe we could move this section into the API reference documentation, as a new page for the lighting shader module (which should probably be renamed to the lights module...).

To make


## Light Sources

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 13, 2019

Contributor

Give JS code examples of how to create a model with a material and set lighting uniforms... explain that we have two Material systems that both support the same lights...

@ibgreen

This comment has been minimized.

Copy link
Contributor

ibgreen commented Mar 27, 2019

Closing, feel free to reopen if comments addressed.

@ibgreen ibgreen closed this Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.