Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new module #981

merged 1 commit into from Mar 14, 2019


None yet
2 participants
Copy link

ibgreen commented Mar 13, 2019

For #724


  • New module:
  • Address concern that new classes like VRAnimationLoop keep adding size to core
  • Avoids creating lots of micro modules for moving minor classes out of core.
  • Converts existing sub-file import setup into a separate module (Currently contains addEvents function).
  • Idea is to use this module to contain classes that are not being used frequently enough to sit in core, initial proposal: AnimationLoopProxy & VRAnimationLoop

Note: A separate intention is to move gltf and scenegraph code to a separate scenegraph module but that requires separating Model from ScenegraphNode and fixing broken examples.

Change List

  • New module
  • Move add-events addon to new module

@ibgreen ibgreen referenced this pull request Mar 13, 2019


WebVR implementation #941

@georgios-uber georgios-uber requested a review from Pessimistress Mar 13, 2019

@ibgreen ibgreen requested review from tsherif and jianhuang01 Mar 13, 2019

@ibgreen ibgreen merged commit 3fe8dbc into master Mar 14, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
license/cla Contributor License Agreement is signed.

@ibgreen ibgreen deleted the ib/addons-module branch Mar 14, 2019


This comment has been minimized.

Copy link
Contributor Author

ibgreen commented Mar 14, 2019

@georgios-uber Go ahead and add the VRAnimationLoop to this new module.

We also need to update docs to show the necessary import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.