Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated lighting uniforms #989

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@jianhuang01
Copy link
Contributor

commented Mar 15, 2019

Change List

  • remove duplicated uniforms

@jianhuang01 jianhuang01 added the chore label Mar 15, 2019

@jianhuang01 jianhuang01 requested review from georgios-uber and ibgreen Mar 15, 2019

@ibgreen
Copy link
Contributor

left a comment

+1

@coveralls

This comment has been minimized.

Copy link

commented Mar 15, 2019

Coverage Status

Coverage remained the same at 44.124% when pulling ee08c13 on fix-phong-lighting into b9cc8a6 on master.

@jianhuang01 jianhuang01 merged commit b1280c0 into master Mar 15, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 44.124%
Details
license/cla Contributor License Agreement is signed.
Details

@jianhuang01 jianhuang01 deleted the fix-phong-lighting branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.