Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the new linter rules #995

Merged
merged 3 commits into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 20, 2019

For #

Background

Change List

  • change to eslintrc.js to allow comments.
  • eslintrc.js changes to ensure test and script directories are not subjected to module import checks (eslint is not aware of the alias system
  • Fix valid import issues resulting from module splits.
  • Add missing modules to package.json
  • eslint-disable as needed in unfinished examples that were recently moved to test/apps (following deck.gl setup)

ibgreen added some commits Mar 20, 2019

@ibgreen ibgreen added the chore label Mar 20, 2019

@ibgreen ibgreen requested review from tsherif and Pessimistress Mar 20, 2019

@ibgreen ibgreen merged commit fc5c605 into master Mar 20, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on ib/linter at 45.982%
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/linter branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.