Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports of external assert #999

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@Pessimistress
Copy link
Contributor

Pessimistress commented Mar 22, 2019

For bundle size optimization

@Pessimistress Pessimistress requested review from tsherif and ibgreen Mar 22, 2019

@ibgreen
Copy link
Contributor

ibgreen left a comment

Thanks. Seems like a custom linter rule could be the way to go here.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 22, 2019

Coverage Status

Coverage decreased (-0.003%) to 46.221% when pulling 4b295f5 on assert into 2fe6b90 on master.

@Pessimistress Pessimistress merged commit 0859f92 into master Mar 22, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 46.221%
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the assert branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.