Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makisu deleted all my files! (in my container) #182

Closed
glenjamin opened this issue Feb 17, 2019 · 3 comments · Fixed by #183
Closed

Makisu deleted all my files! (in my container) #182

glenjamin opened this issue Feb 17, 2019 · 3 comments · Fixed by #183
Labels

Comments

@glenjamin
Copy link

@glenjamin glenjamin commented Feb 17, 2019

I ran makisu in a container using the alpine container, as documented - which seemed to produce my image correctly.

However when I tried to ls it afterwards, I realised my whole filesystem had been deleted.

I realise this is probably related to my use of the --modifyfs feature, but I hadn't realised how intrusive the changes were going to be! Could this be noted in the documentation?

In particular, i'm experimenting with running this on CircleCI - many jobs will want to run some steps after producing the image, so it would be nice if there were a way to enable this.

Please let me know if i'm barking up the wrong tree here!

@yiranwang52

This comment has been minimized.

Copy link
Collaborator

@yiranwang52 yiranwang52 commented Feb 19, 2019

So makisu works in 2 ways:

  1. Runs outside of container, without --modifyfs option (default to false), in which case it doesn't support Dockerfiles with RUN.
  2. Runs inside a empty container with only Makisu binary, with --modifyfs=true option. It also removes all files just in case it's not a clean environment. It supports RUN in this case.

We can make the documentation more clear.
I think your usecase can be achieved with either option.

@dnephin

This comment has been minimized.

Copy link

@dnephin dnephin commented Feb 21, 2019

Thanks for adding to the documentation.

Is there somewhere I could read more about why it must remove all the files? I did not see that in the documentation. Are there ways to mark specific paths to prevent them from being removed?

@aweis89

This comment has been minimized.

Copy link

@aweis89 aweis89 commented Apr 11, 2019

This is an issue when running makisu in Jenkins. The pipeline durability tries to execute commands in the makisu container resulting in the following:

(JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found
sh: touch: not found
sh: sleep: not found```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.