Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to override class members #80

Merged
merged 1 commit into from Feb 11, 2020
Merged

Updates to override class members #80

merged 1 commit into from Feb 11, 2020

Conversation

@elsh
Copy link
Collaborator

elsh commented Feb 9, 2020

No description provided.

@elsh elsh force-pushed the es-kls branch from d696635 to 05a2fc5 Feb 9, 2020
@elsh elsh requested review from rudro, benhjerrild and NicoHinderling Feb 10, 2020
@@ -68,21 +68,29 @@ final class VariableModel: Model {
self.filePath = filepath
}

private func isGenerated(_ name: String) -> Bool {
return name.hasPrefix(.underlyingVarPrefix) || name.hasSuffix(.setCallCountSuffix) || name.hasSuffix(.callCountSuffix) || name.hasSuffix(.subjectSuffix) || name.hasSuffix("SubjectKind") || name.hasSuffix(.handlerSuffix)

This comment has been minimized.

Copy link
@NicoHinderling

NicoHinderling Feb 10, 2020

Member

how come "SubjectKind" isn't its own enum case?

This comment has been minimized.

Copy link
@elsh

elsh Feb 10, 2020

Author Collaborator

ah yes, will update


if matchingParamsFound || extraInitParamCandidates.isEmpty {
needParamedInit = false
}

This comment has been minimized.

Copy link
@NicoHinderling

NicoHinderling Feb 10, 2020

Member

How come we don't need any of this anymore? Admittedly I don't have context on the role that needParamedInit plays, so I'm assuming it's related to that

This comment has been minimized.

Copy link
@elsh

elsh Feb 11, 2020

Author Collaborator

extra init's are still generated for protocol mocks but not for class mocks. this change handles that.

@elsh elsh merged commit 53fe217 into master Feb 11, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.