Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Create @nebula.gl/layers #189
Mar 21, 2019
ibgreen left a comment •
This looks great, it aligns very nicely with the module strategy in other vis.gl repos!
One thing missing here that I think is quite important is to document the module structure. Explain to users (and developers) what modules are available, what they contain etc, including clearly calling out that the
The docs should likely also be lightly reorganized to reflect a per-module structure.
On a separate note, I would suggest not using the directory name
The reason is that most of our vis.gl monorepos have a (non-react) core module (
FWIW, we put our deprecated unscoped modules (luma.gl/deck.gl/loaders.gl) in the
Finally, a nit: I see lots of commented code left in the example, recommend cleaning up asap.