Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude coverage from published module #79

Merged
merged 1 commit into from Nov 12, 2018
Merged

Conversation

vicapow
Copy link
Contributor

@vicapow vicapow commented Oct 11, 2018

Having it in the module seems to have no advantage. This also causes the phabricator-jenkins-plugin to catch this coverage file to detect this as the coverage file used in our repo.

$ find . -name 'cobertura-coverage.xml'
./node_modules/react-digraph/coverage/cobertura-coverage.xml

Having it in the module seems to have no advantage. This also causes the phabricator-jenkins-plugin to catch this coverage file to detect this as the coverage file used in our repo.

````
$ find . -name 'cobertura-coverage.xml'
./node_modules/react-digraph/coverage/cobertura-coverage.xml
````
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@vicapow
Copy link
Contributor Author

vicapow commented Oct 11, 2018

Not sure why the CLA bot thinks I need to sign the CLA. Maybe a bug? I'm an Uber employee

@ajbogh ajbogh merged commit 83f6889 into uber:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants