New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove immutable / use mapbox style diffing #434

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@vicapow
Contributor

vicapow commented Jan 6, 2018

Style diffing using mapbox-gl-style-spec still has some issues with flikr.

http://www.giphy.com/gifs/xULW8EmfshppodKWwU

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jan 6, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jan 6, 2018

CLA assistant check
All committers have signed the CLA.

@vicapow

This comment has been minimized.

Show comment
Hide comment
@vicapow

vicapow Jan 6, 2018

Contributor

Whoops. I didn't see https://github.com/uber/react-map-gl/pull/433/files already exists

Contributor

vicapow commented Jan 6, 2018

Whoops. I didn't see https://github.com/uber/react-map-gl/pull/433/files already exists

@Pessimistress

This comment has been minimized.

Show comment
Hide comment
@Pessimistress

Pessimistress Jan 7, 2018

Contributor

@vicapow ideally we could keep immutable support but no longer require it for diffing. Worst case we can just cast it to a plain JS object.

Contributor

Pessimistress commented Jan 7, 2018

@vicapow ideally we could keep immutable support but no longer require it for diffing. Worst case we can just cast it to a plain JS object.

@vicapow

This comment has been minimized.

Show comment
Hide comment
@vicapow

vicapow Jan 7, 2018

Contributor

Makes sense. From the best I can tell this diff still maintains support for immutable but removes mentions to it.

Contributor

vicapow commented Jan 7, 2018

Makes sense. From the best I can tell this diff still maintains support for immutable but removes mentions to it.

@ibgreen

This comment has been minimized.

Show comment
Hide comment
@ibgreen

ibgreen Jan 8, 2018

Contributor

@vicapow Looks like there is some good stuff here that wasn't covered in @Pessimistress PR. Rebase and repost?

Contributor

ibgreen commented Jan 8, 2018

@vicapow Looks like there is some good stuff here that wasn't covered in @Pessimistress PR. Rebase and repost?

@vicapow

This comment has been minimized.

Show comment
Hide comment
@vicapow

vicapow Jan 8, 2018

Contributor

@ibgreen Thanks! I'll try to follow up and rebase when I get more free time.

Contributor

vicapow commented Jan 8, 2018

@ibgreen Thanks! I'll try to follow up and rebase when I get more free time.

@Pessimistress Pessimistress referenced this pull request Aug 3, 2018

Merged

Remove immutable & use Mapbox's style diffing #559

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment