Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: popup close button click event propagates to map #751

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@Pessimistress
Copy link
Contributor

commented Mar 11, 2019

For #746

Introduced by #628 - Popup._onClick is now called twice (immediate click and single click). The popup should be closed on click event only.

@Pessimistress Pessimistress requested a review from xintongxia Mar 11, 2019

@Pessimistress Pessimistress merged commit 4bddb0f into master Mar 13, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the popup-bug-fix branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.