New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to SSO with Uber Eats #131

Merged
merged 3 commits into from Aug 17, 2018

Conversation

Projects
None yet
4 participants
@thepoofy
Contributor

thepoofy commented Aug 13, 2018

Description: Introduces SupportedAppType to differentiate the API's of AppProtocol. This adds a public API for AppProtocol.isInstalled(Context, SupportedAppType).

LoginManager's API is unchanged and will attempt to SSO with Uber apps in the order defined by SupportedAppType, Uber then Uber Eats.

Some constants were renamed to explicitly define the app they are defined for.

Related issue(s): #130

@thepoofy thepoofy requested review from tyvsmith, itstexter and jck2 Aug 13, 2018

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 13, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 13, 2018

CLA assistant check
All committers have signed the CLA.

@tyvsmith

This comment has been minimized.

Show comment
Hide comment
@tyvsmith

tyvsmith Aug 14, 2018

Member

Can the Eats SSO auth the same scopes as Rides or vice versa? Would there be cases when we didn't want the SSO fallback to Eats and we should make it explicit?

Member

tyvsmith commented Aug 14, 2018

Can the Eats SSO auth the same scopes as Rides or vice versa? Would there be cases when we didn't want the SSO fallback to Eats and we should make it explicit?

@thepoofy

This comment has been minimized.

Show comment
Hide comment
@thepoofy

thepoofy Aug 14, 2018

Contributor

Eats and Rides will be able to authenticate users regardless of the scopes requested. Scopes will be tied to the Client's configuration.

Contributor

thepoofy commented Aug 14, 2018

Eats and Rides will be able to authenticate users regardless of the scopes requested. Scopes will be tied to the Client's configuration.

@tyvsmith

This looks good now.

@thepoofy thepoofy merged commit ca27106 into uber:master Aug 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@thepoofy thepoofy deleted the thepoofy:wv-multi-app-support branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment