Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix XVIZFileLoader: make sure always batchSize files being fetched #264

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@xintongxia
Copy link
Contributor

xintongxia commented Mar 1, 2019

No description provided.

@xintongxia xintongxia requested a review from Pessimistress Mar 1, 2019

@xintongxia xintongxia changed the title fix XVIZFileLoader: make sure there are always batchSize files are be… fix XVIZFileLoader: make sure always batchSize files being fetched Mar 1, 2019

Show resolved Hide resolved modules/core/src/loaders/xviz-file-loader.js
if (!this.isOpen()) {
return;
}

if (startFrame >= this._numberOfFrames) {
this._lastLoadFrame = this._lastLoadFrame + 1;

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 3, 2019

Contributor

Nit: this._lastLoadFrame should only be bumped if the frame actually gets loaded.

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 4, 2019

Author Contributor

I intended to bump _lastLoadFrame before promised is resolved, because the same frame might be fetched more than once if bumped after.

fix XVIZFileLoader: make sure there are always batchSize files are be…
…ing fetched

remove debugging code

remove task queue

resolve comments

resolve comments

fix

@xintongxia xintongxia force-pushed the xx/file-loader branch from 617cc4f to 9ce10cf Mar 6, 2019

@xintongxia xintongxia merged commit 8dc659b into master Mar 11, 2019

7 checks passed

buildkite/streetscape-gl Build #641 passed (4 minutes, 26 seconds)
Details
buildkite/streetscape-gl/chrome Passed (8 seconds)
Details
buildkite/streetscape-gl/docker Passed (3 minutes, 25 seconds)
Details
buildkite/streetscape-gl/eslint Passed (19 seconds)
Details
buildkite/streetscape-gl/node Passed (14 seconds)
Details
buildkite/streetscape-gl/pipeline Passed (12 seconds)
Details
license/cla Contributor License Agreement is signed.
Details

@xintongxia xintongxia deleted the xx/file-loader branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.