Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light settings coordinate system #272

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@Pessimistress
Copy link
Contributor

commented Mar 10, 2019

For uber/xviz#402

Default light positions are in METER_OFFSET coordinate system but did not explicitly state so. At runtime, it falls back to the layer's coordinate system, resulting in an exception when GEOGRAPHIC coordinates are used.

@Pessimistress Pessimistress requested a review from twojtasz Mar 10, 2019

@Pessimistress Pessimistress merged commit d51096e into master Mar 11, 2019

7 checks passed

buildkite/streetscape-gl Build #642 passed (3 minutes, 2 seconds)
Details
buildkite/streetscape-gl/chrome Passed (8 seconds)
Details
buildkite/streetscape-gl/docker Passed (2 minutes, 13 seconds)
Details
buildkite/streetscape-gl/eslint Passed (15 seconds)
Details
buildkite/streetscape-gl/node Passed (10 seconds)
Details
buildkite/streetscape-gl/pipeline Passed (9 seconds)
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the light-bug branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.