From 48187689a7ea80ae37203eaa1c85662bf3c18027 Mon Sep 17 00:00:00 2001 From: Yi Wang Date: Mon, 3 Dec 2018 19:01:02 -0800 Subject: [PATCH] Rename SerialSequenceExecutor Renames `SerialSequenceExecutor` to `ImmediateSerialSequenceExecutor` to better represent the execution is done immediately on the caller thread, since a `ConcurrentSequenceExecutor` limited to a maximum concurrency level of 1 would also be serial. --- Concurrency.xcodeproj/project.pbxproj | 8 ++++---- ...ecutor.swift => ImmediateSerialSequenceExecutor.swift} | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) rename Sources/Concurrency/Executor/{SerialSequenceExecutor.swift => ImmediateSerialSequenceExecutor.swift} (95%) diff --git a/Concurrency.xcodeproj/project.pbxproj b/Concurrency.xcodeproj/project.pbxproj index 000cdc9..ce49a40 100644 --- a/Concurrency.xcodeproj/project.pbxproj +++ b/Concurrency.xcodeproj/project.pbxproj @@ -7,7 +7,7 @@ objects = { /* Begin PBXBuildFile section */ - 41B94843210A4744007E59C8 /* SerialSequenceExecutor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41B9483F210A4744007E59C8 /* SerialSequenceExecutor.swift */; }; + 41B94843210A4744007E59C8 /* ImmediateSerialSequenceExecutor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41B9483F210A4744007E59C8 /* ImmediateSerialSequenceExecutor.swift */; }; 41B94844210A4744007E59C8 /* SequenceExecutor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41B94840210A4744007E59C8 /* SequenceExecutor.swift */; }; 41B94845210A4744007E59C8 /* ConcurrentSequenceExecutor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41B94841210A4744007E59C8 /* ConcurrentSequenceExecutor.swift */; }; 41B94846210A4744007E59C8 /* Task.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41B94842210A4744007E59C8 /* Task.swift */; }; @@ -34,7 +34,7 @@ /* End PBXContainerItemProxy section */ /* Begin PBXFileReference section */ - 41B9483F210A4744007E59C8 /* SerialSequenceExecutor.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SerialSequenceExecutor.swift; sourceTree = ""; }; + 41B9483F210A4744007E59C8 /* ImmediateSerialSequenceExecutor.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ImmediateSerialSequenceExecutor.swift; sourceTree = ""; }; 41B94840210A4744007E59C8 /* SequenceExecutor.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SequenceExecutor.swift; sourceTree = ""; }; 41B94841210A4744007E59C8 /* ConcurrentSequenceExecutor.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ConcurrentSequenceExecutor.swift; sourceTree = ""; }; 41B94842210A4744007E59C8 /* Task.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Task.swift; sourceTree = ""; }; @@ -74,7 +74,7 @@ 41B9483E210A4744007E59C8 /* Executor */ = { isa = PBXGroup; children = ( - 41B9483F210A4744007E59C8 /* SerialSequenceExecutor.swift */, + 41B9483F210A4744007E59C8 /* ImmediateSerialSequenceExecutor.swift */, 41B94840210A4744007E59C8 /* SequenceExecutor.swift */, 41B94841210A4744007E59C8 /* ConcurrentSequenceExecutor.swift */, 41B94842210A4744007E59C8 /* Task.swift */, @@ -224,7 +224,7 @@ 41B94845210A4744007E59C8 /* ConcurrentSequenceExecutor.swift in Sources */, OBJ_28 /* AtomicInt.swift in Sources */, OBJ_29 /* AtomicReference.swift in Sources */, - 41B94843210A4744007E59C8 /* SerialSequenceExecutor.swift in Sources */, + 41B94843210A4744007E59C8 /* ImmediateSerialSequenceExecutor.swift in Sources */, OBJ_30 /* CountDownLatch.swift in Sources */, ); runOnlyForDeploymentPostprocessing = 0; diff --git a/Sources/Concurrency/Executor/SerialSequenceExecutor.swift b/Sources/Concurrency/Executor/ImmediateSerialSequenceExecutor.swift similarity index 95% rename from Sources/Concurrency/Executor/SerialSequenceExecutor.swift rename to Sources/Concurrency/Executor/ImmediateSerialSequenceExecutor.swift index 1245e65..667fc78 100644 --- a/Sources/Concurrency/Executor/SerialSequenceExecutor.swift +++ b/Sources/Concurrency/Executor/ImmediateSerialSequenceExecutor.swift @@ -17,20 +17,20 @@ import Foundation /// An executor that executes sequences of tasks serially from the -/// caller thread. +/// caller thread as soon as the execute method is invoked. /// /// - note: Generally this implementation should only be used for debugging /// purposes, as debugging highly concurrent task executions can be very /// challenging. Production code should use `ConcurrentSequenceExecutor`. /// - seeAlso: `SequenceExecutor`. /// - seeAlso: `Task`. -public class SerialSequenceExecutor: SequenceExecutor { +public class ImmediateSerialSequenceExecutor: SequenceExecutor { /// Initializer. public init() {} /// Execute a sequence of tasks serially from the given initial task - /// on the caller thread. + /// on the caller thread, immediately. /// /// - parameter initialTask: The root task of the sequence of tasks /// to be executed.