Add tests for ListenIP interface/IP scoring #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicato
reviewed
Jan 5, 2017
| bestScore := -1 | ||
| var bestIP net.IP | ||
| // Select the highest scoring IP as the best IP. | ||
| for _, iface := range interfaces { | ||
|
|
witriew
reviewed
Jan 6, 2017
| @@ -0,0 +1,80 @@ | |||
| // Copyright (c) 2015 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
Keeping it 2015 to keep it consistent with the rest of the code, apparently the "year of first publication" is what we want:
http://www.contentious.com/2007/01/07/copyright-notice-is-the-year-really-necessary/
| { | ||
| msg: "non-local up ipv4 IPAddr address", | ||
| iface: net.Interface{Flags: net.FlagUp}, | ||
| addr: &net.IPNet{IP: testIP}, |
There was a problem hiding this comment.
Nice catch, thanks
| { | ||
| msg: "non-local down ipv6 address", | ||
| iface: net.Interface{}, | ||
| addr: &net.IPAddr{IP: net.ParseIP("2001:db8:a0b:12f0::1")}, |
There was a problem hiding this comment.
Declare this IP at the top as well (dedup L65).
prashantv
commented
Jan 6, 2017
| @@ -0,0 +1,80 @@ | |||
| // Copyright (c) 2015 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
Keeping it 2015 to keep it consistent with the rest of the code, apparently the "year of first publication" is what we want:
http://www.contentious.com/2007/01/07/copyright-notice-is-the-year-really-necessary/
| { | ||
| msg: "non-local up ipv4 IPAddr address", | ||
| iface: net.Interface{Flags: net.FlagUp}, | ||
| addr: &net.IPNet{IP: testIP}, |
There was a problem hiding this comment.
Nice catch, thanks
| { | ||
| msg: "non-local down ipv6 address", | ||
| iface: net.Interface{}, | ||
| addr: &net.IPAddr{IP: net.ParseIP("2001:db8:a0b:12f0::1")}, |
| bestScore := -1 | ||
| var bestIP net.IP | ||
| // Select the highest scoring IP as the best IP. | ||
| for _, iface := range interfaces { | ||
|
|
witriew
approved these changes
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some prefactoring for #554