Skip to content

Conversation

@tahmidhasan-zz
Copy link
Contributor

Workflow level tests that utilize the workflow mock for testing segfault whenever they try to increment a metric using the scope. We fix the scope initialization here to prevent that from happening.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.17% when pulling 57b284f on tahmid.addtestscope into ca7f2d9 on master.

@tahmidhasan-zz tahmidhasan-zz merged commit fe45bdc into master Dec 17, 2018
@tahmidhasan-zz tahmidhasan-zz deleted the tahmid.addtestscope branch December 17, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants