-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baz endpoint benchmarks #69
Conversation
benchmarks/benchserver/main.go
Outdated
backend := testBackend.CreateHTTPBackend(PORT) | ||
err := backend.Bootstrap() | ||
serverTChannel(logger) | ||
serveHTTP(logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: move the Wait() call up here outside the serve()
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -92,7 +92,7 @@ func endpointTmpl() (*asset, error) { | |||
return nil, err | |||
} | |||
|
|||
info := bindataFileInfo{name: "endpoint.tmpl", size: 6955, mode: os.FileMode(420), modTime: time.Unix(1492819038, 0)} | |||
info := bindataFileInfo{name: "endpoint.tmpl", size: 6955, mode: os.FileMode(420), modTime: time.Unix(1492822079, 0)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out why these timestamps change :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is wired, no templates were modified...
FYI some local benchmark runs on baz endpoint:
Benchmarks on contacts endpoint for reference: