Mute events in timeline #106

Merged
merged 24 commits into from Apr 17, 2014

Conversation

Projects
None yet
2 participants
Contributor

piatra commented Mar 10, 2014

for #49
Still to do:

  • Apply filter to new events (that load after scrolling to the bottom)
  • Remove filters
dashboard/css/style.css
+ opacity: 1;
+}
+
+.timeline-item--field-hiden {
@mihneadb

mihneadb Mar 10, 2014

Contributor

hidden

Contributor

mihneadb commented Mar 10, 2014

Nice, but you should also filter the already loaded events. :)

Contributor

piatra commented Mar 10, 2014

Still to do: If you keep adding filters you end up with an empty page and the loading spinner that never triggers any events

Contributor

piatra commented Mar 11, 2014

Done. Review please :) @mihneadb

Contributor

mihneadb commented Mar 11, 2014

screen shot 2014-03-11 at 23 10 17
Why not make the filter area wider?
The "mute event" trigger should be more obvious - I spent some time looking for it and I knew to look for something :).
It would be great to be able to click on a label and get the items to show again (thinking toggling display:none).

Thanks! (Also, needs a rebase)

dashboard/js/timeline.js
@@ -17,6 +21,15 @@
return ret;
});
+ Handlebars.registerHelper('parseEventType', function(event) {
+ console.log(event);
@mihneadb

mihneadb Apr 11, 2014

Contributor

let's get rid of this

+ return 'unkown events';
+ }
+ var l = event.length;
+ return event.substr(0, l-5).toLowerCase() + ' events';
@mihneadb

mihneadb Apr 11, 2014

Contributor

for some reason for stars I see "View only WatchEvent"

@piatra

piatra Apr 11, 2014

Contributor

Fixed in new-er commit :)

dashboard/js/timeline.js
- fragment.appendChild($item[0]);
+ if (App.Timeline.filter.length) { // if there are filters
+ if ($item.data('event') && App.Timeline.filter.indexOf($item.data('event')) == -1) { // if the current item is not filtered out
+ console.log($item.data('event'));
@mihneadb

mihneadb Apr 11, 2014

Contributor

drop this

Contributor

mihneadb commented Apr 11, 2014

Nice!

  • maybe the eye icon should be colored #999?
  • would be nice to see a list of what filters you have applied and be able to turn them off one by one (since you already have this implemented, it's just a matter of exposing it to the user)

Thanks!

Contributor

piatra commented Apr 11, 2014

Not sure which is the best way to show that to the user. Suggestions ?

On Fri, Apr 11, 2014 at 1:26 PM, Mihnea Dobrescu-Balaur <
notifications@github.com> wrote:

Nice!

  • maybe the eye icon should be #999?
  • would be nice to see a list of what filters you have applied and be
    able to turn them off one by one (since you already have this implemented,
    it's just a matter of exposing it to the user)

Thanks!

Reply to this email directly or view it on GitHubhttps://github.com/uberVU/elasticboard/pull/106#issuecomment-40190151
.

Andrei Oprea

Contributor

mihneadb commented Apr 11, 2014

Either display a wide bar, something like in the graphs:
screen shot 2014-04-11 at 12 38 35

Or let's save some space on the right and align the components like:
screen shot 2014-04-11 at 12 39 00

Contributor

piatra commented Apr 12, 2014

Not ready for merge but would be nice to check for 🐛s
Added filters to the right side of the timeline

Contributor

mihneadb commented Apr 12, 2014

Nice, I like the functionality.

I know it's not ready yet but noting some ideas down, just in case:

screen shot 2014-04-12 at 23 37 59
Would rather use the type of the event (or do we really not know)?

  • display a "no filters yet" on the right when there are none
  • hovering on a "filter" option should change bg of the item
  • action for clicking a set filter (on the right) should be obvious (UI feedback)
  • when using "display only this" vs "don't display this" the UI is the same on the right hand side, should be different

Thanks!

piatra added some commits Apr 14, 2014

Better filtering for timeline items
Use a backbone view for the timeline items which listens for a filter collection
when that collection changes it filters through the items. Easier to manage
Better UI feedback for filters
Added X on hover to signal closing
Added title that explicitly says that click will remove
Added :hover state for better interaction
Contributor

mihneadb commented Apr 16, 2014

Sweet! Please make it so that in the hover menu you can click on the whole item (not just the text) and let's 🚢.

Contributor

piatra commented Apr 16, 2014

Yes 💃

Contributor

mihneadb commented Apr 17, 2014

Thanks!

mihneadb added a commit that referenced this pull request Apr 17, 2014

@mihneadb mihneadb merged commit 0f8f30f into uberVU:master Apr 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment