Skip to content

feat: faucet #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat: faucet #1

merged 3 commits into from
Nov 27, 2023

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 13, 2023

@0x4007
Copy link
Member

0x4007 commented Nov 13, 2023

You should always link the pull request to the open issue. If its in a different repository, then you paste in the full URL after the "Resolves" keyword.

@rndquu rndquu self-requested a review November 17, 2023 14:36
@rndquu
Copy link
Member

rndquu commented Nov 20, 2023

@Keyrxng

  1. Pls review https://github.com/ubq-testing/faucet/pull/1 and merge if it's fine
  2. I can't run the worker locally via yarn start because I get the Worker exceeded resource limits error all the time. Do you have such an issue?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 23, 2023

Sorry for the slow reply been a busy week, trying to scale out of my 9-5 at the minute.

I'll check things this evening.

As for 2, yeah I was able to fire maybe 3 transactions locally before I hit that same issue, restarting the server gave me another few attempts. A side-effect of the local env I assumed, my actual worker doesn't have any such issues.

feat: add docs + minor fixes
@rndquu
Copy link
Member

rndquu commented Nov 27, 2023

Sorry for the slow reply been a busy week, trying to scale out of my 9-5 at the minute.

I'll check things this evening.

As for 2, yeah I was able to fire maybe 3 transactions locally before I hit that same issue, restarting the server gave me another few attempts. A side-effect of the local env I assumed, my actual worker doesn't have any such issues.

You mean there is no Worker exceeded resource limits error on a prod worker deployed to cloudflare, right?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 27, 2023

Yeah rndquu but not exactly, done a little digging and cpu intensive workers can get that error in prod but mine hasn't at least for the interactions I've put to it and comparing that against the ENS implementation the throughput on theirs vs ours would be minimal so afaik it's only because it's a dev env it's throwing that.

@rndquu rndquu merged commit e95a68a into ubiquity:development Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Faucet" Service
3 participants