Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Revert "cmdutils: allow specifying the file for -report"

This reverts commit 841bf0e.
This does not fully work as the file is used before the filename is parsed
so not all information is written in the specified file.
  • Loading branch information...
commit 4e6fa5be3ce5a66e9420377dceedffb6cadfdad4 1 parent 50d3a1a
@michaelni michaelni authored Nicolas George committed
Showing with 0 additions and 14 deletions.
  1. +0 −11 cmdutils.c
  2. +0 −2  cmdutils.h
  3. +0 −1  cmdutils_common_opts.h
View
11 cmdutils.c
@@ -528,17 +528,6 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
return 0;
}
-int opt_report_file(void *optctx, const char *opt, const char *arg)
-{
- report_file = fopen(arg, "w");
- if (!report_file) {
- av_log(NULL, AV_LOG_ERROR, "Failed to open report \"%s\": %s\n",
- arg, strerror(errno));
- return AVERROR(errno);
- }
- return 0;
-}
-
int opt_report(const char *opt)
{
char filename[64];
View
2  cmdutils.h
@@ -84,8 +84,6 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg);
int opt_report(const char *opt);
-int opt_report_file(void *optctx, const char *opt, const char *arg);
-
int opt_max_alloc(void *optctx, const char *opt, const char *arg);
int opt_cpuflags(void *optctx, const char *opt, const char *arg);
View
1  cmdutils_common_opts.h
@@ -19,6 +19,5 @@
{ "debug" , HAS_ARG, {.func_arg = opt_codec_debug}, "set debug flags", "flags" },
{ "fdebug" , HAS_ARG, {.func_arg = opt_codec_debug}, "set debug flags", "flags" },
{ "report" , 0, {(void*)opt_report}, "generate a report" },
- { "report_file", HAS_ARG, {.func_arg = opt_report_file}, "filename for storing the report" },
{ "max_alloc" , HAS_ARG, {.func_arg = opt_max_alloc}, "set maximum size of a single allocated block", "bytes" },
{ "cpuflags" , HAS_ARG | OPT_EXPERT, {.func_arg = opt_cpuflags}, "force specific cpu flags", "flags" },
Please sign in to comment.
Something went wrong with that request. Please try again.