Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong button colors when removing contact #64

Closed
cibersheep opened this Issue Dec 16, 2018 · 12 comments

Comments

Projects
9 participants
@cibersheep
Copy link
Contributor

cibersheep commented Dec 16, 2018

When removing a contact, button colors are inverted.

Question: Do you want to remove contact?
Answer: yes (negative action. Should be red)
Answer: no (neutral answer. Could be ash)

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-7 via automation Dec 31, 2018

@UniversalSuperBox UniversalSuperBox moved this from To do to QA in OTA-7 Dec 31, 2018

@advocatux

This comment has been minimized.

Copy link
Contributor

advocatux commented Jan 1, 2019

Device: Nexus 5 (hammerhead)
Channel: RC
Version: 2018-W01 (really 2019-W01)

I don't know which color combination would be better, or the "correct" one for that matter, but I can confirm that it's still happening the way Joan describes: 'green' for 'Yes', 'red' for 'No'.

@cibersheep

This comment has been minimized.

Copy link
Contributor Author

cibersheep commented Jan 2, 2019

Devices: Cooler and Vegeta
Channel: RC
2018-W01

Color combination still green for "Yes" and red for "No".
sudo ubpots-qa update made no difference.

@erik-kueng

This comment has been minimized.

Copy link

erik-kueng commented Jan 2, 2019

Fairphone 2
rc
2018-W01

Yes is green. No is red

@NeoTheThird

This comment has been minimized.

Copy link
Member

NeoTheThird commented Jan 3, 2019

I can confirm that #65 did not fix this, yes is still green, no still red.

Opinion: I find this counter-intuitive. From my understanding, even though deleting a contact is a negative action, clicking yes is a positive action, because you give positive confirmation to a previous action (whatever that might be). Would it not be better to have the "do you really want to" dialogs exactly the same everywhere accross the ui? In any case, it might be a good idea to make a decision on wether confirmation dialogs are a separate action or inherit the positivity or negativity of the action pending confirmation.

@NeoTheThird NeoTheThird reopened this Jan 3, 2019

OTA-7 automation moved this from QA to To do Jan 3, 2019

@cibersheep

This comment has been minimized.

Copy link
Contributor Author

cibersheep commented Jan 3, 2019

Interesting. Green as a «yes» go and delete it?
For now we have been using «wrong» the colors: yes/ok is always green and cancel is always red.
It «should be» gren/red/blue (depending on if they're destructive, safe or neutral) as the main option and grey the other options.

Going further, we could change the question:
Question: Do you want to remove contact?
Answer: Delete (negative action. Should be red)
Answer: Cancel (neutral answer. Could be ash)

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Jan 5, 2019

Ah, I see what happened here. address-book-app is a deb, so a PR should be made to xenial to land it in the image.

I'd say that since this happened, the language change to the dialog would be a good idea for OTA-8.

@cibersheep

This comment has been minimized.

Copy link
Contributor Author

cibersheep commented Jan 6, 2019

I see... silly me and my not-know-what-a-branch-is syndrome:
#70

@UniversalSuperBox UniversalSuperBox removed this from To do in OTA-7 Jan 7, 2019

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-8 via automation Jan 7, 2019

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Feb 18, 2019

Fixed by #70

OTA-8 automation moved this from To do to QA Feb 18, 2019

@toehold

This comment has been minimized.

Copy link

toehold commented Feb 28, 2019

I get a Red Button saying: Remove and a grey Cancel Button. Ubuntu 16.06 (2019-W09)

@jezek

This comment has been minimized.

Copy link

jezek commented Feb 28, 2019

FP2 (2019-W09)

  • remove button red
  • cancel button gray
@Danfro

This comment has been minimized.

Copy link
Contributor

Danfro commented Feb 28, 2019

as above remove = red, cancel = gray on E5 running RC 2019-W09

edit:
BUT remove is not translated, that does come up in English. Cancel is translated.

bildschirmfoto von 2019-02-28 23-09-24

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Feb 28, 2019

Nexus 7 (flo), rc2019-W09. Red for remove, Grey to cancel.

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.