Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting any buteo-sync account causes tests to fail #73

Closed
UniversalSuperBox opened this Issue Jan 22, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@UniversalSuperBox
Copy link
Member

UniversalSuperBox commented Jan 22, 2019

It seems like commit 6077d89 did not update the tests for address-book-app to handle the changes to the ContactListView. The tests must be updated before the app can be built.

A log of the error can be found here: https://ci.ubports.com/blue/organizations/jenkins/address-book-app/detail/xenial_-_aba-control/1/pipeline#step-33-log-782

This was surfaced after fixing #72, but still blocks the merge of the fix.

@mardy

This comment has been minimized.

Copy link
Member

mardy commented Jan 23, 2019

Yes, it's likely that it happens because of my change: at that time CI was not running the tests. I'll fix it!

@mardy mardy self-assigned this Jan 23, 2019

@mardy

This comment has been minimized.

Copy link
Member

mardy commented Feb 16, 2019

Fixed!

@mardy mardy closed this Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.