Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contacts search #74

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
4 participants
@kugiigi
Copy link

kugiigi commented Jan 25, 2019

Fixed #56

I removed a workaround that was used before.
I think it's not needed anymore and causes the issue we have in search.
I'm not exactly sure if this is really the case so maybe someone more knowledgeable on this can review these changes and of course more and deeper tests 馃槃

Fixed #56
Removed old workaround in "onContactsChanged"

@hummlbach hummlbach requested a review from mardy Jan 25, 2019

@hummlbach

This comment has been minimized.

Copy link
Collaborator

hummlbach commented Jan 25, 2019

@kugiigi very cool! lets see what @mardy has to say.

@mardy

This comment has been minimized.

Copy link
Member

mardy commented Feb 12, 2019

The code looks correct, and indeed the comment about the workaround fails to explain why the issue existed in the first place.

Just to be sure, since I cannot test this right away: can please someone else confim that this fixes the search issue?

@UniversalSuperBox
Copy link
Member

UniversalSuperBox left a comment

I wasn't able to reproduce the issue before, but this change causes no noticeable side effects.

@UniversalSuperBox UniversalSuperBox merged commit 6050cff into ubports:xenial Feb 18, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.