Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting new bootsplash image #10

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2018

The interesting part is that OPO has already the partition mounted in recovery:
https://github.com/ubports/android_device_oneplus_bacon-1/blob/ubp-5.1/rootdir/root/fstab.bacon - but why there exists also a recovery.fstab file?
Will the recovery understand to flash boot.bin instead of splash.img?

@Flohack74 Flohack74 requested a review from mariogrip Sep 24, 2018

@NeoTheThird
Copy link
Member

left a comment

CAREFUL!

The Oneplus One's logo partition is very different from the other devices. Are you sure this works? If you flash a logo partition like the one of the FP2 (eg a renamed bitmap file), you hard-brick your device, because the bootloader can not start. Did you test this? Who created this file? I'm only aware of one alternative logo partition that Cibersheep created with bitflipping, to simply remove the "powered by android" part, Is that what this is?

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 28, 2018

Its from @rubencarneiro and I flashed it on my OPO, no issues :) - Did not even know there can be a problem. Let me post a screenshot as a proof.

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 28, 2018

grafik

@NeoTheThird

This comment has been minimized.

Copy link
Member

commented Sep 29, 2018

How, what, huh? Does your bootloader work without issues? What do you see, when you reboot to fastboot?

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2018

I see
grafik
And the usual white Fastboot Mode logo on the screen ;)

@NeoTheThird

This comment has been minimized.

Copy link
Member

commented Sep 29, 2018

mind = blown. I'll have to see that for myself.

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2018

You got bacon or A0001 model?

@rubencarneiro

This comment has been minimized.

Copy link

commented Sep 29, 2018

It will work without any problemas, opo partition for logo is LOGO

@Flohack74

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2018

Yeah but we need to be careful since the recovery updater will look for a mounted partition, so the partition table must be correct. See my link to fstab.bacon - Now the question is, how does the updater know which is the name of the partition? From filename?

@rubencarneiro

This comment has been minimized.

Copy link

commented Sep 29, 2018

Yeah the partion is not mention o the recovery.fstab you can fix that by fins the device partitions using cat /ptoc/MTD
Por cat /MTD

@Flohack74 Flohack74 requested a review from NeoTheThird Jun 17, 2019

@NeoTheThird
Copy link
Member

left a comment

lgtm gj

@Flohack74 Flohack74 merged commit b8b9e4e into ubp-5.1 Jun 18, 2019

@Flohack74 Flohack74 added this to In progress in OTA-10 via automation Jun 18, 2019

@Flohack74 Flohack74 moved this from In progress to QA in OTA-10 Jun 18, 2019

@Flohack74 Flohack74 moved this from QA to In progress in OTA-10 Jun 20, 2019

@UniversalSuperBox UniversalSuperBox moved this from In progress to QA in OTA-10 Jul 3, 2019

@UniversalSuperBox UniversalSuperBox removed this from QA in OTA-10 Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.