New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented on-screen keyboard theme support #57

Merged
merged 12 commits into from Dec 29, 2018

Conversation

Projects
9 participants
@kugiigi
Copy link
Contributor

kugiigi commented Dec 18, 2018

This implementation includes the following:

  • Support for loading the color value from JSON files
  • Replaced Border Images with Rectangle with borders (Magnifier, ExtendedKeysSelector, LanguageMenu)
  • Adding a new item in the schema (theme)
  • Updated LanguageMenu with the new ListItem component for better theme support
  • Added border support for each key

kugiigi added some commits Nov 24, 2018

Update BorderedBlack.json
Changed action keys color
Update BorderedGrey.json
Changed action key color
Update BorderedWhite.json
Changed the action key color
Update LanguageMenu.qml
 - Set max line count to 2
 - Use default divider color
@mariogrip
Copy link
Member

mariogrip left a comment

other then some small nitpicking, it LGTM :+1

Show resolved Hide resolved data/styles/ubuntu/themes/SuruBlack.json Outdated
Show resolved Hide resolved qml/keys/ExtendedKeysSelector.qml Outdated
Show resolved Hide resolved qml/keys/ExtendedKeysSelector.qml Outdated
Show resolved Hide resolved qml/keys/Magnifier.qml Outdated
Show resolved Hide resolved qml/keys/Magnifier.qml Outdated
Update SuruBlack.json
fixed spacing

kugiigi added some commits Dec 21, 2018

Update SuruDark.json
fixed spacing
Update JustGrey.json
fixed spacing
Update BorderedGrey.json
fixed spacing
Update Magnifier.qml
fixed spacing
@cibersheep

This comment has been minimized.

Copy link

cibersheep commented Dec 21, 2018

Let's test it in dev channel :)

@UniversalSuperBox
Copy link
Member

UniversalSuperBox left a comment

I've done a cursory test of every language available manually on a few different themes, comparing them with the keyboard without these changes. I only found #60, which happens with the keyboard without these changes.

The only possible problem I found is that the Japanese keyboard does not handle the theming very well. It's visible but doesn't honor your colors:

screenshot20181228_124356408

It's still readable and I'd be comfortable merging with this issue. It's up to you.

@mariogrip
Copy link
Member

mariogrip left a comment

LGTM 👍

@kugiigi

This comment has been minimized.

Copy link
Contributor

kugiigi commented Dec 29, 2018

maybe we can have separate bugs and PRs for layouts that has to be updated to support the themes.

@mariogrip

This comment has been minimized.

Copy link
Member

mariogrip commented Dec 29, 2018

@kugiigi Sounds like a good idea, let's merge this for now.

@mariogrip mariogrip merged commit ddf8aeb into ubports:xenial Dec 29, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@mariogrip mariogrip added this to Done in OTA-7 Dec 29, 2018

@10JML01

This comment has been minimized.

Copy link

10JML01 commented Jan 1, 2019

Device: BQ E5HD and M10FHD
Channel: rc
Version: 2018-W01

Works great!

@advocatux

This comment has been minimized.

Copy link

advocatux commented Jan 1, 2019

Device: Nexus 5 (hammerhead)
Channel: RC
Version: 2018-W01 (really 2019-W01)

Everything looks OK except the Japanese layout issue mentioned already.

@cibersheep

This comment has been minimized.

Copy link

cibersheep commented Jan 2, 2019

Works great and even the tap & hold on space bar to move the cursor works better now

@erik-kueng

This comment has been minimized.

Copy link

erik-kueng commented Jan 2, 2019

Fairphone 2
rc
2018-W01

Works great.

@NeoTheThird

This comment has been minimized.

Copy link
Member

NeoTheThird commented Jan 3, 2019

Great job! Works very well.

@NeoTheThird NeoTheThird moved this from QA to Done in OTA-7 Jan 3, 2019

@Stefano0101

This comment has been minimized.

Copy link

Stefano0101 commented Jan 3, 2019

Fantastic job well done! Meizu Pro 5, testing Ota-7. 2018-W01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment