New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiss-french layout #61

Merged
merged 8 commits into from Dec 31, 2018

Conversation

Projects
None yet
3 participants
@UniversalSuperBox
Copy link
Member

UniversalSuperBox commented Dec 30, 2018

This fixes the syntax of the Swiss-French keyboard layout. It also updates the keyboard's translations. It also moves the files to a correct location so that they can be detected and the language name can be replaced with the translated name.

@UniversalSuperBox UniversalSuperBox requested a review from dobey Dec 30, 2018

@mariogrip
Copy link
Member

mariogrip left a comment

Small question, otherwise LGTM 👍

@@ -32,6 +32,7 @@ function languageIdToName(languageId)
if (languageId == "fa") return i18n.tr("Persian");
if (languageId == "fi") return i18n.tr("Finnish");
if (languageId == "fr") return i18n.tr("French");
if (languageId == "fr-ch") return i18n.tr("French\n(Swiss)");

This comment has been minimized.

@mariogrip

mariogrip Dec 30, 2018

Member

Why do you make a new line?

This comment has been minimized.

@dobey

dobey Dec 30, 2018

Contributor

Because it belongs on a new line? Why should there not be a new one? I'd argue these should all have {} as well, but I'm not going to make Dalton fix that in this PR.

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Dec 31, 2018

Well, that dismissed the reviews.

@mariogrip, I'm just following the style of the file.

@UniversalSuperBox UniversalSuperBox requested a review from dobey Dec 31, 2018

@mariogrip
Copy link
Member

mariogrip left a comment

LGTM 👍

@UniversalSuperBox UniversalSuperBox merged commit 1438b5e into xenial Dec 31, 2018

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@UniversalSuperBox UniversalSuperBox deleted the xenial_-_french-suisse-fix branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment