Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake does not update the .pot file #52

Closed
ChristianPauly opened this issue Oct 15, 2018 · 5 comments

Comments

Projects
3 participants
@ChristianPauly
Copy link
Collaborator

commented Oct 15, 2018

A lot of new strings are not translated. It looks like the .pot file haven't been updated.

@Flohack74

This comment has been minimized.

Copy link
Member

commented Oct 15, 2018

See here, that was the latest push from Weblate (which was stuck but now should be good): #49 - however I would not call this lot of new strings....

@Flohack74

This comment has been minimized.

Copy link
Member

commented Oct 15, 2018

Ah you mean smth different: Yes, anyone who is compiling the app and makes changes to the translations must also check in/ commit the pot file. Otherwise we wont get the changes. I can try to make it this time, but it must be a responsibility of the PR authors.

@Danfro

This comment has been minimized.

Copy link

commented Mar 8, 2019

I didn't know that the pot file needs to be updated with the PR as well. I thought that was done with the build and then transferred to weblate. I will remember that. PR/MR should not be merged without the pot file then maybe?

Just spotted, that the new settingspage does contains mostly untranslated strings. Other apps do have the same problem. Maybe that information needs to be spread/repeated to everyone developing?

@ChristianPauly

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 11, 2019

It looks like there is a problem with cmake. The .pot file hasnt got an update since 2016-07-21...

The cmake file in po/CMakeLists.txt is executed every time but it does not update the .pot file.

@ChristianPauly ChristianPauly changed the title Missing translations CMake does not update the .pot file Mar 11, 2019

@Danfro

This comment has been minimized.

Copy link

commented Mar 11, 2019

So does that mean the .pot file is updated via script? So do translators have to commit the pot file as @Flohack74 said "last year"? Or is that information maybe outdated? Or am I mixing up things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.