Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use the system theme #89

Closed
hummlbach opened this issue Apr 6, 2019 · 2 comments

Comments

@hummlbach
Copy link

commented Apr 6, 2019

It would be cool to have the option to use the system theme.
Instead of using a slider button to switch between light and dark theme, an ExpandableListItem with the options Light, Dark and System could be used. (Already done here: https://gitlab.com/ubports/apps/clock-app/blob/master/app/alarm/AlarmSettingsPage.qml#L227 but unfortunately the clock doesn't know how to query available themes.)

@ChristianPauly

This comment has been minimized.

Copy link
Collaborator

commented Jun 2, 2019

Shouldn't we just remove the feature to set a custom theme? When there is a global setting for the dark mode, do all apps need their own switch to ignore this theme?

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

No, it is very possible that a user would want one or a few apps to be a certain theme all the time. Unless the option gets in the way of other changes, I'd call it an accessibility feature and leave it there.

bhdouglass added a commit that referenced this issue Jun 30, 2019

Merge pull request #107 from ubports/SystemThemeSupport
Add an option to use the system theme. Fixes #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.