Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #84 #106

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@ChristianPauly
Copy link
Collaborator

commented Jun 2, 2019

No description provided.

@ChristianPauly ChristianPauly merged commit aeb4ba8 into xenial Jun 3, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Flohack74

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

I would ask you to not merge your own pull requests without an approving review by someone else. 4-eyes principle should be always met ;)

@Flohack74 Flohack74 deleted the contextClickFix branch Jun 3, 2019

@ChristianPauly

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 3, 2019

I fully agree but last pull request Ive waited more than a month for approval and last time Ive asked im core apps room, someone said (don't know who it was, someone like Brian) its okay to just merge it by myself because we don't have the manpower for this.

@Flohack74

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Ok then please put this in the notes here. And also delete the temp branch after merge, so we stay clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.