Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary list item highlights #57

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@kugiigi
Copy link
Contributor

kugiigi commented Oct 18, 2018

This removes the list item highlights in the settings page and new recipient page.

Note: This is just my opinion because it seems like they are unnecessary and doesn't look good.
They would make sense if the list item contents are displayed in an additional column (adaptivelayout) but that doesn't seem to be the case at the moment.

@cibersheep

This comment has been minimized.

Copy link

cibersheep commented Nov 9, 2018

Hello, thanks for the PR.
Would you like to provide a test click?

@kugiigi

This comment has been minimized.

Copy link
Contributor Author

kugiigi commented Nov 11, 2018

I believe this app is in deb and I didn't compile this actually since I developed and tested it directly on my phone. sorry...

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 11, 2018

Hmm why the CI did not trigger ? I need to investigate. Then we could have a deb package for testing.

kugiigi added some commits Oct 18, 2018

Update Messages.qml
Fixes #47 in ubports
Update SettingsPage.qml
Changed UbuntuListView to standard ListView to remove unnecessary item highlights
Update NewRecipientPage.qml
Set highlightSelected of ContactListView to false to remove unnecessary item highlights

@UniversalSuperBox UniversalSuperBox merged commit e6b11d1 into ubports:xenial Feb 12, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@kugiigi kugiigi deleted the kugiigi:xenial_-_enhancements branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.