Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link without error #118

Closed
cibersheep opened this Issue Dec 1, 2018 · 11 comments

Comments

Projects
7 participants
@cibersheep
Copy link

cibersheep commented Dec 1, 2018

Device: m10 HD Xenial RC
Steps: go to a inexistent url (for example: http://www.aceadventuregames.com/ this link desn't exist anymore)
Behaviour: weird blank page with three buttons?
Expected: Error message saying «Link couldn't be opened» or similar

Images

Morph:
imatge

Oxide:
imatge

(«Network error. It seems that you are having problems to show link. Check your connection and try to load the page again»)

@advocatux

This comment has been minimized.

Copy link

advocatux commented Dec 1, 2018

Yep, it doesn't show an external error but fwiw the 'internal' error is:

qml: [JS] (chrome-error://chromewebdata/:4696) Uncaught ReferenceError: jstProcess is not defined

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Dec 1, 2018

Hmm, are both of these from the same network at the same time? Some DNS providers will redirect to advertisement pages when you request a site that doesn't exist.

@balcy balcy added the bug label Dec 1, 2018

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Dec 1, 2018

I confirm that I see the "strange page" for (not existing) www.ubports1234.com as well. (and my DNS provider does not redirect the page)
On the same network desktop browsers show the proper message "trouble connecting to ..."

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Dec 1, 2018

I think we can use https://doc.qt.io/qt-5/qml-qtwebengine-webengineview.html#loadingChanged-signal for that no longer sure, because Browser already is set to display the error sheet for "WebEngineView.LoadFailedStatus"

@cibersheep

This comment has been minimized.

Copy link
Author

cibersheep commented Dec 2, 2018

Hmm, are both of these from the same network at the same time? Some DNS providers will redirect to advertisement pages when you request a site that doesn't exist.

If I understood correctly: I confirm that both screenshots are from the same wifi connection. One on Oxide on Vivid, the other on Morph on Xenial RC

Later I can test on mobile data if it's of any help...

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-8 via automation Jan 7, 2019

@UniversalSuperBox UniversalSuperBox moved this from To do to QA in OTA-8 Jan 7, 2019

@jezek

This comment has been minimized.

Copy link

jezek commented Mar 1, 2019

FP2 (2019-W09)
In morph browser after opening non-existent page (www.ubports1234.com), only a blank (white) page with one grayish button with tranlated "Refresh page" text is shown. No other text or error messages.

EDIT: this behaviour was observed with SuruDark theme. For default Ambiance theme, the text is shown properly. See 2nd comment below.

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Mar 1, 2019

@jezek, which language are you currently using? This is the page in en_US:

image

@jezek

This comment has been minimized.

Copy link

jezek commented Mar 1, 2019

@UniversalSuperBox my languge is sk_SK.
Now, I've tested it with en_US. Gone to "System Settigs -> Language & Text -> Display Language" and selected "English (United States)" and restarted phone.
After visiting a non-existen page, the same happens:
screenshot20190301_171040211 resized 25

EDIT:
This seems to be an theming issue. On Ambiance theme and both languages (en_US, sk_SK) the network error as in your picture is shown.

So on default Ambiance theme it works. (On SuruDark, there seems to be a font color issue, but this is not a part of this bug)

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Mar 1, 2019

Ah, that might be related to your dark theme. Could you file a new issue about not being able to see the error page with a dark theme?

@haeckle

This comment has been minimized.

Copy link

haeckle commented Mar 1, 2019

Fixed on Nexus 4 with 2019-W09

@erik-kueng

This comment has been minimized.

Copy link

erik-kueng commented Mar 2, 2019

FP2
2019-W09
could not reproduce this issue

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.