Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morph doesn't properly support system themes for tabs headers #142

Closed
mattbel10 opened this Issue Jan 26, 2019 · 6 comments

Comments

Projects
6 participants
@mattbel10
Copy link

mattbel10 commented Jan 26, 2019

  • Device: Meizu Pro 5

  • Channel: 16.04 Devel

  • Build: 2019-01-24

Steps to reproduce
Go to UT Tweak Tool and select a theme different from the default "Ambiance" (either SuruDark or SuruGradient).

Expected behavior
The Morph browser app is expected to get the theme appropriately for each piece of the window.

Actual behavior
Instead, the SuruDark theme causes the disappearance of the cross used to close each open tab (look at the attached picture for the sake of clarity).

screenshot20190119_112016290

@10JML01

This comment has been minimized.

Copy link

10JML01 commented Feb 4, 2019

Same for BQ E5hd (vegetahd) and BQ M10FHD (frieza) in the current rc. A good dark theme support is important and can be easier on the eyes and battery.

@dobey dobey closed this in #146 Feb 8, 2019

dobey added a commit that referenced this issue Feb 8, 2019

Merge pull request #146 from balcy/xenial_-_tabtheme
Theme support for the tab list (Rectangle instead of BorderImage) and current zoom text. Fixes #142

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-8 via automation Feb 8, 2019

@UniversalSuperBox UniversalSuperBox moved this from To do to QA in OTA-8 Feb 8, 2019

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 1, 2019

Suru dark theme selected in UTTT on Nexus 7 flo (2019-W-09). When viewing list of tabs in Morph Browser the 'close tab' crosses are all visible

@jezek

This comment has been minimized.

Copy link

jezek commented Mar 1, 2019

FP2 (2019-W09)

viewing tabs in morph browser:

  • theme SuruDark - crosses visible
  • theme SuruGradient - crosses visible (thus the theme itself is somewhat weird, but this is not part of this bug)
@mattbel10

This comment has been minimized.

Copy link
Author

mattbel10 commented Mar 1, 2019

I cannot reproduce anymore the described issue, therefore it is fixed thanks to @dobey.

Device: Meizu Pro5
Build: Ubuntu 16.04 (2019-W09)

@haeckle

This comment has been minimized.

Copy link

haeckle commented Mar 1, 2019

Fixed on Nexus 4 with 2019-W09 (tested with SuruDark and SuruGradient)

@erik-kueng

This comment has been minimized.

Copy link

erik-kueng commented Mar 2, 2019

FP2
2019-W09
could not reproduce issue, tested with SuruDark and SuruGradient)

  • in SuruGradient the "finished" button in the tab-screen can not be read

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.