New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media does not stop when a tab is closed #59

Closed
UniversalSuperBox opened this Issue Oct 16, 2018 · 7 comments

Comments

Projects
5 participants
@UniversalSuperBox
Copy link
Member

UniversalSuperBox commented Oct 16, 2018

Moved from ubports/ubuntu-touch#913

The browser continuous playing of a sound (f.e. Youtube audio) even the panel with such multimedia has been closed. It is necessary to close the browser completely to stop the playing

  • Device: BQ M10 Aquaris FHD

Expected behavior

I appreciate that murph keeps playing e.g. IPTV even I switch the browser to another tab opened, but the browser must stop playing audio when I close the tab with e.g. IPTV, Youtube etc...

Actual behavior

The browser continuous playing of a sound (f.e. Youtube audio) even the panel with such multimedia has been closed. It is necessary to close the browser completely to stop the playing

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Oct 17, 2018

what I can say is that in BrowserTab.qml there is a problem:

        if (webview) {
            initialUrl = webview.url
            initialTitle = webview.title
            initialIcon = webview.icon
restoreState = webview.currentState
            //restoreType = Oxide.WebView.RestoreCurrentS$
            webview.destroy()
            gc()
        }
    }

the "restoreState =..." cannot be executed, because the webview does not have this property.
BUT: If the unload function does work after removing the line, at least on Aquaris 4.5 the tab is unloaded not only if you close it, but on tab switch as well. So the music would stop in this case

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Oct 17, 2018

file:///usr/share/morph-browser/webbrowser/BrowserTab.qml:125: Error: Cannot assign [undefined] to QString

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Nov 8, 2018

I think because of memory problems on low spec devices (#93) we should properly unload the tab, so no background music from other tabs

@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Nov 11, 2018

#96

@ferrettim

This comment has been minimized.

Copy link

ferrettim commented Nov 27, 2018

device:Nexus 5
channel: RC 2018-W48
issue solved. Unable to reproduce

@tjrhodes

This comment has been minimized.

Copy link

tjrhodes commented Nov 27, 2018

Device: FP2
System Build: 2018-W48

issue solved, unable to reproduce.

BUT that's because the background tabs are unloaded, which is another issue. It's currently impossible to keep playing audio in one tab and browse in another.

@UniversalSuperBox UniversalSuperBox moved this from To do to Accepted in OTA-6 QA Tracker Nov 28, 2018

@hsbyter

This comment has been minimized.

Copy link

hsbyter commented Dec 2, 2018

fixed in 2018-w48 m10 fhd
Could not reproduce issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment