New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close current tab / close single window #131

Merged
merged 1 commit into from Dec 29, 2018

Conversation

Projects
None yet
2 participants
@balcy
Copy link
Collaborator

balcy commented Dec 26, 2018

  • morph-browser.qml: delete the closed window from the list before destruction
    (closing one window does no longer close the others)
    fixes #35
    probably fixes #130
  • WebViewImpl.qml: add hideZoomMenu() and hideContextMenu()
  • NavigationBar.qml: add close button that is only visible in "tabList" mode
  • other QML files get the tabListMode property and closeTabRequested() signal
    (it is now possible to close the current tab)
    fixes #50
- morph-browser.qml: delete the closed window from the list before de…
…struction

(closing one window does no longer close the others)
- WebViewImpl.qml: add hideZoomMenu() and hideContextMenu()
- NavigationBar.qml: add close button that is only visible in "tabList" mode
- other QML files get the tabListMode property and closeTabRequested() signal
(it is now possible to close the current tab)
@mariogrip
Copy link
Member

mariogrip left a comment

LGTM 👍

@mariogrip mariogrip merged commit 99c717c into ubports:xenial Dec 29, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@balcy balcy deleted the balcy:xenial_-_closewindowsandtabs branch Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment