New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"keep display on" for audio playback and fullscreen (video) #132

Merged
merged 1 commit into from Dec 29, 2018

Conversation

Projects
2 participants
@balcy
Copy link
Collaborator

balcy commented Dec 26, 2018

turn off screensaver while the browser window is active and "recentlyAudible" or "isFullScreen" property of the current webview is true

fixes #71

turn off screensaver while the browser window is active and "recently…
…Audible" or "isFullScreen" property of the current webview is true
@balcy

This comment has been minimized.

Copy link
Collaborator

balcy commented Dec 27, 2018

do you think we should create a setting entry for that ? Some users might not know, that the phone stays unlocked in those situations.

@mariogrip

This comment has been minimized.

Copy link
Member

mariogrip commented Dec 29, 2018

Awesome!

This was the default behavior of oxide, so i think its fine for now :)

But an option would be a good thing to add tough.

@mariogrip
Copy link
Member

mariogrip left a comment

LGTM 👍

@mariogrip mariogrip merged commit 5a8034d into ubports:xenial Dec 29, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@mariogrip mariogrip added this to Done in OTA-7 Dec 29, 2018

@balcy balcy deleted the balcy:xenial_-_screensaver branch Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment