Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back favicons #141

Merged
merged 9 commits into from Feb 9, 2019

Conversation

Projects
5 participants
@balcy
Copy link
Collaborator

balcy commented Jan 12, 2019

favicon-fetcher: use the image:// url provided by QtWebEngine (do not cache them with morph)

for bookmarks still use the local cache for favicons

favicon-fetcher: directly use the image:// url provided by QtWebEngin…
…e (do not cache them with morph)

for bookmarks still use the local cache for favicons
@balcy

This comment has been minimized.

Copy link
Collaborator Author

balcy commented Jan 12, 2019

note:

  • newly created bookmarks will cache the icons (like webbrowser-app did)
  • existing bookmarks can be "repaired" by removing and adding them again as bookmark. They have (until this PR) saved the "image://favicon/<FaviconUrl>" url, which can only used while QtWebEngine has temporarily cached the icon (e.g. tab of this page currently open)
Show resolved Hide resolved src/app/webbrowser/TabComponent.qml Outdated
Show resolved Hide resolved src/app/webbrowser/Browser.qml Outdated

balcy added some commits Feb 8, 2019

@UniversalSuperBox UniversalSuperBox merged commit 22ec9bd into ubports:xenial Feb 9, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@balcy balcy deleted the balcy:xenial_-_favicon branch Feb 9, 2019

@UniversalSuperBox UniversalSuperBox added this to In progress in OTA-8 via automation Feb 9, 2019

@UniversalSuperBox UniversalSuperBox moved this from In progress to QA in OTA-8 Feb 9, 2019

@jezek

This comment has been minimized.

Copy link

jezek commented Feb 28, 2019

FP2 (2019-W09)
tested on 3 sites: gmail.com, memrise.com. slovniky.juls.savba.sk

  • in tabs all 3 favicons are displayed corectly.
  • in bookmarks the favicons where not shown for allready created bookmarks. After bookmark resave, only the favicon for slovniky.juls.savba.sk is not displayed. The other two favicons are correct.

Verdict: tab favicons are all back, bookmark favicons are partialy back (not working for all sites, for which tab favicons are working)

Note; in bookmarks, the first is duckduckgo. the favicon is not shown and can not resave, cause I have no bookmark for ddg.

EDIT: As for now all bookmark favicons (except the first duckduckgo) are displayed correctly. Maybe a restart was needed, maybe someting was fixed.

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 1, 2019

Nexus 7 flo, 2019-W09. Favicons are back

@haeckle

This comment has been minimized.

Copy link

haeckle commented Mar 1, 2019

Works on Nexus 4 with 2019-W09

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 2, 2019

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 2, 2019

BQ E4.5 2019-09
Favicons are back...except for 'homepage' in bookmarks which does not display a favicon in the bookmark list, no matter what address one puts in for the homepage via browser settings.

@balcy

This comment has been minimized.

Copy link
Collaborator Author

balcy commented Mar 3, 2019

yeah that's right the homepage is without icon. I've looked into the code, and there is no icon put in there. Would be sth. we could add im the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.