Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme support for the tab list (Rectangle instead of BorderImage) and current zoom text #146

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@balcy
Copy link
Collaborator

balcy commented Jan 31, 2019

fixes #142

@balcy balcy requested a review from nfsprodriver Jan 31, 2019

@myii

This comment has been minimized.

Copy link

myii commented Feb 8, 2019

@balcy Thanks for this. After a discussion on Telegram, I went ahead and hacked these directly onto my device. The tab list is now displaying fine. How can I test the current zoom text?

@balcy

This comment has been minimized.

Copy link
Collaborator Author

balcy commented Feb 8, 2019

without the change with SuruDark "Current Zoom: 100%" (at the bottom of the zoom menu) was not visible.

@myii

This comment has been minimized.

Copy link

myii commented Feb 8, 2019

@dobey

dobey approved these changes Feb 8, 2019

Copy link
Member

dobey left a comment

Looks OK to me, though would be nice to have regression tests for all the QML (but seems to be lacking in browser in general).

@dobey dobey merged commit 490782b into ubports:xenial Feb 8, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@balcy balcy deleted the balcy:xenial_-_tabtheme branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.