Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenial errordarktheme #174

Merged
merged 2 commits into from Apr 8, 2019

Conversation

@balcy
Copy link
Collaborator

commented Mar 30, 2019

fixes #164

balcy added some commits Mar 2, 2019

themed color / background color of error sheet
themed background color of browser view
make background color of webview not transparent (text files will no …
…longer readable with the dark theme)

rather a user script that adapts the default background and text to the theme might be used

@UniversalSuperBox UniversalSuperBox self-requested a review Apr 4, 2019

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

When you say "Text files will no longer be readable with dark theme", how would I test that? I tried opening up a build log from ci.ubports.com (which should be a text file) and it appeared fairly normally.

@balcy

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 8, 2019

Hi Dalton, actually that comit only took back another commit with that I have set the background color of the webview, to the background color of the theme.
I reverted it because .txt files would then be black on black, because the default foreground color for the webview cannot be set via a property, and stays black even with the dark theme.

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Ah, that explains why it works now!

@UniversalSuperBox UniversalSuperBox merged commit fb80407 into ubports:xenial Apr 8, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@balcy balcy deleted the balcy:xenial_-_errordarktheme branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.