Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate certificate error "backToSafety" button to the ErrorSheet #185

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@balcy
Copy link
Collaborator

commented May 8, 2019

fixes #116

@UniversalSuperBox
Copy link
Member

left a comment

Sorry for the delay...

After clicking "Cancel" on the certificate error dialog, the error page is shown offering to take the user back to safety or try refreshing the page.

image

This seems to be what was discussed in #116. If @cibersheep approves of this design, I'll merge it.

By going to badssl.com/dashboard, we can see that behavior for bad SSL requests coming from a page has not changed: The attempted navigation causes a user-visible error. This is not expected (the errors should probably be silently denied), but again, it is not a regression.

While trying to test this, I went to check out my favorite "broken SSL" site, allrecipes. Instead of throwing a ton of SSL errors like it normally did, the browser went into an endless loop trying to flash the error page. Not sure what's going on and the site loads over 500 resources between all of its JavaScript and the things which the JavaScript load in turn... Makes debugging almost impossible and the issue doesn't seem to be caused by these changes anyway.

@UniversalSuperBox UniversalSuperBox merged commit a7495b0 into xenial Jun 1, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@UniversalSuperBox UniversalSuperBox deleted the xenial_-_certificateerrordialog branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.