New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar theme #74

Merged
merged 4 commits into from Oct 29, 2018

Conversation

Projects
5 participants
@mateosalta
Copy link
Contributor

mateosalta commented Oct 25, 2018

This introduces a theme to the scrollbar, marius suggested css that should have a nicely styled scroll bar. The scrollbar has a transparent background, and looks similar to the system scrollbar https://t.me/ubports/165236

Possible regression, some sites may reserve space for the scrollbar on the right side of the screen - resulting in a gap, instead of a nice overlay.

Testing on a few sites to see if the result is sutible suggested.

mateosalta added some commits Oct 18, 2018

@mariogrip mariogrip merged commit 4d87532 into ubports:xenial Oct 29, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@tjrhodes

This comment has been minimized.

Copy link

tjrhodes commented Nov 26, 2018

Hey, Looks good on white backgrounds, gets lost on dark backgrounds. Rather than being an overlay it appears to take up page width?

@Andrissk

This comment has been minimized.

Copy link

Andrissk commented Nov 28, 2018

nexus 5 2018-w48 - basically the same observations as tjrhodes posted above

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Nov 28, 2018

Yes, it looks like the scrollbar does take up some width on the page. This is expected compared to most desktop browsers, which also have the scrollbar taking up page width (about 17 pixels, I found by cursory searching). The scrollbar being visible on dark backgrounds is not expected, though. @tjrhodes, could you file another bug with your findings?

@UniversalSuperBox UniversalSuperBox moved this from To do to Accepted in OTA-6 QA Tracker Nov 28, 2018

@mateosalta

This comment has been minimized.

Copy link
Contributor

mateosalta commented Dec 14, 2018

yeah, ubuntu.web creates a nice scrollbar. wonder if that code is css? or something diffrent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment