Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Only use Hybris when available #6

Merged
merged 1 commit into from May 25, 2021
Merged

Only use Hybris when available #6

merged 1 commit into from May 25, 2021

Conversation

z3ntu
Copy link
Contributor

@z3ntu z3ntu commented May 18, 2020 •
edited

Please check if the hybris files are still getting built with this change, it was more or less blindly applied from the Unity8-Arch repo

mariogrip
mariogrip suggested changes May 27, 2020
View reviewed changes
Copy link
Member

@mariogrip mariogrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be cleaner if we if(Hybris) the add_subdirectory commands instead of if-ing the whole cmake files

@z3ntu
Copy link
Contributor Author

z3ntu commented Jul 12, 2020

Done. Builds fine in postmarketOS

@UniversalSuperBox
Copy link
Member

src/ubuntu/application/touch/ and src/ubuntu/hardware/ are still built with this change.

@UniversalSuperBox UniversalSuperBox merged commit a8f95a2 into ubports:xenial May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariogrip mariogrip mariogrip requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@z3ntu @UniversalSuperBox @mariogrip @vanyasem