Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suru Theme Dial controls oversized #29

Open
lduboeuf opened this issue May 28, 2019 · 4 comments

Comments

@lduboeuf
Copy link

commented May 28, 2019

hi, just tested a page with Dial controls.
Size seems to be fine in System theme but not in Suru (overlaps). i've tried either by defining width and height in Dial and implicitWidth and implicitHeight ).

screenshot20190528_103810049
screenshot20190528_103734351

@lduboeuf lduboeuf changed the title Suru Theme and Dial controls size Suru Theme Dial controls oversized May 28, 2019

@cibersheep

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

Mmm... interesting. On what device are you on?
What element are you using? Do you have a link to the code?

@lduboeuf

This comment has been minimized.

Copy link
Author

commented May 28, 2019

i'm on Nexus 5.
You can find an example here: https://github.com/lduboeuf/sfxr-qt/blob/master/ui/SliderGroup.qml#L71
bascally, it is Dial controls within a gridLayout

@lduboeuf

This comment has been minimized.

Copy link
Author

commented May 28, 2019

i've tested to force a width/height or implicitWidth/implicitHeight to a low value, and nothing is taken into account

@bhdouglass

This comment has been minimized.

Copy link
Member

commented May 30, 2019

So the problem here is that the background for the dial (which is the actual circle) has a minimum size of 192 which is bigger than the size you want to set your in that app. I updated it in #30 to 64 which is what is being used in the material design style. Which makes your app look correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.