Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed problematic width setting in the Label component #27

Merged
merged 1 commit into from May 9, 2019

Conversation

@bhdouglass
Copy link
Member

commented May 9, 2019

This fixes #19.

Apparently the problem with that is that Suru was setting the width of the Label component but the width should be controlled by the Column. I checked the other QQC2 styles and none of them set the width or line height so I removed both of those properties (and they were also marked as experimental anyways).

@bhdouglass bhdouglass requested a review from cibersheep May 9, 2019

@fredldotme

This comment has been minimized.

Copy link

commented May 9, 2019

Fixes issues reported in #19, good job!

@fredldotme

This comment has been minimized.

Copy link

commented May 9, 2019

Is Label the only component with custom width? Theoretically this issue could come up with other items inside Row/Column as well.
Also, may I add my "approved stamp" on it?

@bhdouglass

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

As far as I can tell Label is the only one doing this. And of course you can mark it as approved :)

@cibersheep

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Ouh! Now that you bring that up, on Ubuntu.Components Label acts weird (in a good sense) so that might be a «downbloodline kinda bug»? Something we might heritaged :)

I'll try to test it later today

@cibersheep
Copy link
Collaborator

left a comment

Beautiful! Good work

@cibersheep cibersheep merged commit cc061ff into xenial May 9, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@bhdouglass

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

I believe the Ubuntu components label is all custom, so the problem probably isn't related.

@bhdouglass

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.