Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QtLocale with CLDR-34 metadata from Q3/2018 #4

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
3 participants
@Flohack74
Copy link
Member

Flohack74 commented Jan 10, 2019

This is a contribution to ubports/ubuntu-touch#655

@tsimonq2
Copy link
Member

tsimonq2 left a comment

Description: Update of CLDR locale data to v34
 Multiple requests were made to update to a newer locale version of Qt to include more languages

This should wrap at 80 characters (with new lines also being indented the same).

Origin: http://archive.ubuntu.com/ubuntu/pool/main/q/qtbase-opensource-src/qtbase-opensource-src_5.9.5+dfsg.orig.tar.xz
Reviewed-by: <name and email of a reviewer, optional>

If Reviewed-by isn't filled in, it shouldn't be there.
Additionally, I would try to choose something different for the origin. We're talking about the origin of the patch, not of the original tarball.

@Flohack74 Flohack74 self-assigned this Jan 10, 2019

@Flohack74 Flohack74 added this to In progress in OTA-8 via automation Jan 10, 2019

@tsimonq2

This comment has been minimized.

Copy link
Member

tsimonq2 commented Jan 11, 2019

Technically Last-Update: 2019-01-10 should now be Last-Update: 2019-01-11, but I don't think it will make a difference.

ACK.

@tsimonq2 tsimonq2 merged commit da626c8 into xenial Jan 11, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

OTA-8 automation moved this from In progress to QA Jan 11, 2019

@Flohack74 Flohack74 deleted the xenial_-_update-cldr-34 branch Jan 11, 2019

@jezek

This comment has been minimized.

Copy link

jezek commented Mar 1, 2019

how do we make tests, to see, if this bug is solved?

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 1, 2019

@Flohack74

This comment has been minimized.

Copy link
Member Author

Flohack74 commented Mar 3, 2019

You can select SC as language from the menu now. However, it lacks translation since its not an official Ubuntu language. But this is another issue...

@jezek

This comment has been minimized.

Copy link

jezek commented Mar 4, 2019

FP2 (2019-W9) - confirmed, there is a Sardinian (Italy) option in Language selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.