Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in patch for display label #4

Merged
merged 3 commits into from Jun 15, 2019

Conversation

@mardy
Copy link
Member

commented May 29, 2019

This will almost certainly be merged upstream soon.

This change will allow us to get rid of a hack we have in the addressbook, where we improperly use the "tag" of a contact as a way to group contacts by their initial letter.

Once this is merged, we will switch to use this new field in addressbook-app, so we can use the tag field for actual tags (should we want to).

@mardy mardy requested a review from mariogrip May 29, 2019

@UniversalSuperBox
Copy link
Member

left a comment

Wait... For the test failure, xvfb-run needs to be run with the arguments --server-args "-screen 0 1024x768x24". If we can do that, then tests should start.

@mardy mardy force-pushed the xenial_-_mercontacts branch from 0971ee0 to 1e05cf7 Jun 15, 2019

@mardy

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2019

Wait... For the test failure, xvfb-run needs to be run with the arguments --server-args "-screen 0 1024x768x24". If we can do that, then tests should start.

Thanks! That, plus another environment variable, did the trick! Please review it again :-)

@UniversalSuperBox UniversalSuperBox merged commit fda2347 into xenial Jun 15, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@UniversalSuperBox UniversalSuperBox deleted the xenial_-_mercontacts branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.