Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read orientation overrides from Android property (V.2) #9

Conversation

@peat-psuwit
Copy link
Contributor

commented Jul 22, 2019

This separate config from code, and make it easier to add overrides for other devices in the future.

This PR changes the approach by using a separate prop for each camera. To override camera number N, set property named aal.camera.orientations.<N>.

Supersedes #6 & #8, and is the framework for fixing ubports/ubuntu-touch#1180.

peat-psuwit added some commits Jul 19, 2019

Read orientation overrides from Android property
This separate config from code, and make it easier to add overrides for
other devices in the future.

@peat-psuwit peat-psuwit changed the title [WIP] Read orientation overrides from Android property (V.2) Read orientation overrides from Android property (V.2) Jul 23, 2019

@peat-psuwit peat-psuwit requested a review from UniversalSuperBox Jul 23, 2019

@UniversalSuperBox
Copy link
Member

left a comment

It appears that there's a bug in ota-push that prevents the M10, E5, and E4.5 images from being rebuilt until the Ubuntu image changes. So, I've tested this on all my Qualcomm trash (heh). It doesn't appear to have made anything worse (ubports/ubuntu-touch#1174), so let's get it merged and test in devel.

@UniversalSuperBox UniversalSuperBox merged commit 9014b4e into ubports:xenial Jul 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.