This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Return only appropriate system-image channels; release properly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This codebase already used the dictionary unpacking operator (**), which was added in Python3.5. Therefore, 3.4 support was already broken and should be removed officially.
Prior to this commit, get_channels would return every channel which was available on the system-image server, which was not at all desirable. Some changes to the test helpers were needed to make this happen. All tests were previously written to assume only the nexus7 was available, and my new test cases needed a different device as well. Fixes #12
UniversalSuperBox
added a commit
to ubports/system-settings
that referenced
this pull request
Jul 6, 2020
This check was only useful before we simplified the directory structure of our system-image server. This leads to showing a lot of duplicate channels, where only one option can actually be used. The issue this worked around is solved correctly by ubports/system-image#13
|
Tested on the Xperia X. Much better, it now only shows edge and "Development" on arm64. I haven't tried switching to devel yet though as it's my daily driver. Should this still show up on a device which doesn't have devel for the architecture? |
|
Hmm. Technically yes, that is correct. You're being shown |
UniversalSuperBox
added a commit
to ubports/system-settings
that referenced
this pull request
Jul 17, 2020
This check was only useful before we simplified the directory structure of our system-image server. This leads to showing a lot of duplicate channels, where only one option can actually be used. The issue this worked around is solved correctly by ubports/system-image#13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important part of this PR is reducing the number of channels returned by
com.canonical.SystemImage GetChannelsover dbus. However, there is more technical debt to remove from system-image, including testing on the wrong version of Python and improper release hygiene.Fixes #12
Should be merged with ubports/system-settings#242