Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: 1026 added continuous integration-workflow.ml #1030

Open
wants to merge 1 commit into
base: master
from

Conversation

@robertbegna
Copy link

robertbegna commented Nov 15, 2019

Hello, I set up a workflow file for github actions by following the instructions at this link. https://help.github.com/en/actions/automating-your-workflow-with-github-actions/configuring-a-workflow
I added a basic configuration set up for your app, hope that will suffice for now.

Copy link
Member

NeoTheThird left a comment

Awesome, thank you for your contribution! Some small adaptions required, then we can get this merged :)

#obtained from github market place
# MIT License


This comment has been minimized.

Copy link
@NeoTheThird
with:
node-version: ${{ matrix.node }}
- run: npm install
- run: npm test

This comment has been minimized.

Copy link
@NeoTheThird

NeoTheThird Nov 15, 2019

Member

We don't have test configured for this repo, but npm run lint would be available. You could also add another step for building, also on different platforms, since github actions seems to support that. See the readme for build documentation.

@NeoTheThird

This comment has been minimized.

Copy link
Member

NeoTheThird commented Nov 20, 2019

Hey, are you still working on this? Would love to get this merged, if you get a chance to look at my review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.